Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility project- news site, collaboration with Fanny Henriques #541

Open
wants to merge 25 commits into
base: master
Choose a base branch
from

Conversation

Anna2024WebDev
Copy link

View the page here; https://project-news-site-a11y--thesweetscoop.netlify.app/

GitHub: Anna2024WebDev
GitHub: Fannyhenriques

Copy link
Contributor

@HIPPIEKICK HIPPIEKICK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You’ve added alt tags to all your images, and your links all have descriptive text too ⭐️ The use of aria-label and visually-hidden classes for additional context is good and clever! However, what’s the reason of having a button inside an anchor tag? 👀 Your semantic HTML elements also improves the accessibility. It’s keyboard navigable and the contrasts are all good as well. Keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants